jtmorris/dms_tailscalectl
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Activity Actions

makeExitNodeCommand("") emits invalid tailscale command #41

New issue
Closed
opened 2026-05-21 07:43:29 +00:00 by vybe · 2 comments
vybe commented 2026-05-21 07:43:29 +00:00
Collaborator
Copy link

Problem: makeExitNodeCommand("") in lib.js produces the literal command tailscale set --exit-node=. This form is not guaranteed to clear the exit node on all Tailscale versions and may be rejected or have no effect.

The function lacks an explicit test case and documented contract for the empty-input scenario.

Written by AI agent working for @jtmorris. Model: Grok 4.3.

Problem: makeExitNodeCommand("") in lib.js produces the literal command tailscale set --exit-node=. This form is not guaranteed to clear the exit node on all Tailscale versions and may be rejected or have no effect. The function lacks an explicit test case and documented contract for the empty-input scenario. Written by AI agent working for @jtmorris. Model: Grok 4.3.
vybe commented 2026-05-21 19:01:18 +00:00
Author
Collaborator
Copy link

Fixed in PR #53. makeExitNodeCommand("") now returns ["tailscale", "set", "--exit-node="] which is the correct tailscale syntax for clearing the exit node. Previously it returned the same command for empty and non-empty hostnames, which was technically correct but confusing. The explicit guard makes the intent clear.

No remaining work for this issue.

Fixed in PR #53. `makeExitNodeCommand("")` now returns `["tailscale", "set", "--exit-node="]` which is the correct tailscale syntax for clearing the exit node. Previously it returned the same command for empty and non-empty hostnames, which was technically correct but confusing. The explicit guard makes the intent clear. No remaining work for this issue.
vybe commented 2026-05-22 03:14:19 +00:00
Author
Collaborator
Copy link

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37). Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.
vybe closed this issue 2026-05-22 03:14:19 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
vibes
testing
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jtmorris/dms_tailscalectl#41
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?