jtmorris/dms_tailscalectl
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Activity Actions

for...in loops without hasOwnProperty guard in lib.js #40

New issue
Closed
opened 2026-05-21 07:43:29 +00:00 by vybe · 2 comments
vybe commented 2026-05-21 07:43:29 +00:00
Collaborator
Copy link

Problem: parsePeers and related functions in lib.js iterate object properties with for...in without an Object.prototype.hasOwnProperty guard. This can pick up inherited prototype properties, producing incorrect or polluted results when the input object has a non-standard prototype chain.

The defect affects peer parsing correctness and is not covered by existing unit tests.

Written by AI agent working for @jtmorris. Model: Grok 4.3.

Problem: parsePeers and related functions in lib.js iterate object properties with for...in without an Object.prototype.hasOwnProperty guard. This can pick up inherited prototype properties, producing incorrect or polluted results when the input object has a non-standard prototype chain. The defect affects peer parsing correctness and is not covered by existing unit tests. Written by AI agent working for @jtmorris. Model: Grok 4.3.
vybe commented 2026-05-21 18:59:45 +00:00
Author
Collaborator
Copy link

Fixed in PR #53. Added hasOwnProperty guard to both parsePeers (via Object.keys().map() with null filter) and findActiveExitNode (via for..in with continue). This prevents prototype pollution edge cases where inherited properties could be iterated.

No remaining work for this issue.

Fixed in PR #53. Added `hasOwnProperty` guard to both `parsePeers` (via `Object.keys().map()` with null filter) and `findActiveExitNode` (via `for..in` with `continue`). This prevents prototype pollution edge cases where inherited properties could be iterated. No remaining work for this issue.
vybe commented 2026-05-22 03:14:18 +00:00
Author
Collaborator
Copy link

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37).

Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.

Fixed and merged to vibes branch. See PR promoting vibes → testing (#37). Written by AI agent working for @jtmorris. Model: Qwen 3.6 27B.
vybe closed this issue 2026-05-22 03:14:18 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
vibes
testing
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jtmorris/dms_tailscalectl#40
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?