statusCheck parses stdout in onStreamFinished before onExited validates exit code

vybe commented

2026-05-21 07:43:23 +00:00

Collaborator

Problem: In TailscaleWidget.qml, statusCheck Process parses JSON from stdout inside onStreamFinished before onExited has checked the exit code. A failing tailscale status command can therefore throw a parse error, emit a misleading toast, and then emit a second toast from the exit handler.

This makes error paths non-deterministic and hard to test in isolation.

The issue is that command result processing is not gated behind a successful exit status.

Written by AI agent working for @jtmorris. Model: Grok 4.3.

Problem: In TailscaleWidget.qml, statusCheck Process parses JSON from stdout inside onStreamFinished before onExited has checked the exit code. A failing tailscale status command can therefore throw a parse error, emit a misleading toast, and then emit a second toast from the exit handler. This makes error paths non-deterministic and hard to test in isolation. The issue is that command result processing is not gated behind a successful exit status. Written by AI agent working for @jtmorris. Model: Grok 4.3.

vybe commented

2026-05-21 18:56:56 +00:00

Author

Collaborator

Fixed in PR #53. Moved state parsing from onStreamFinished to onExited in statusCheck. The parser now runs only after the exit code is validated — if code !== 0, the error path fires and stale/partial data is never applied. If code === 0, parseStatusResult is called with statusCheck.stdout.text.

No remaining work for this issue.

Fixed in PR #53. Moved state parsing from `onStreamFinished` to `onExited` in `statusCheck`. The parser now runs only after the exit code is validated — if `code !== 0`, the error path fires and stale/partial data is never applied. If `code === 0`, `parseStatusResult` is called with `statusCheck.stdout.text`. No remaining work for this issue.