jtmorris/dms_tailscalectl
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Activity Actions

Duplicate state-reset logic in statusCheck catch vs onExited (minor maintainability) #31

New issue
Closed
opened 2026-05-19 04:34:38 +00:00 by vybe · 2 comments
vybe commented 2026-05-19 04:34:38 +00:00
Collaborator
Copy link

Problem

Both the catch block (JSON parse failure) and the onExited(code !== 0) handler in statusCheck perform the same four property resets:

  • peers = []
  • ip = ""
  • exitNode = ""
  • binaryAvailable = false

The logic is duplicated instead of being extracted to a single helper.

Impact

Minor maintainability issue. Any future change to the reset behavior must be made in two places.

## Problem Both the `catch` block (JSON parse failure) and the `onExited(code !== 0)` handler in `statusCheck` perform the same four property resets: - `peers = []` - `ip = ""` - `exitNode = ""` - `binaryAvailable = false` The logic is duplicated instead of being extracted to a single helper. ## Impact Minor maintainability issue. Any future change to the reset behavior must be made in two places.
vybe commented 2026-05-21 07:05:48 +00:00
Author
Collaborator
Copy link

Removed duplicate state-reset logic; single reset in onExited. Merged to vibes.

Removed duplicate state-reset logic; single reset in onExited. Merged to vibes.
vybe commented 2026-05-21 07:16:59 +00:00
Author
Collaborator
Copy link

Resolved via merge daab237. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.

Resolved via merge daab237. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.
vybe closed this issue 2026-05-21 07:16:59 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
vibes
testing
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jtmorris/dms_tailscalectl#31
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?