Toggle error message can report the opposite action due to stale isConnected state

vybe commented

2026-05-19 04:07:32 +00:00

Collaborator

Problem

In toggleTailscale(), the error message logic in toggleProcess.onExited decides the action verb by reading the live property:

var action = root.isConnected ? "disconnect" : "connect"

root.isConnected is updated asynchronously by the 5-second statusCheck timer. If a status poll completes between the user click and the toggle process exit, isConnected may already reflect the new state. The resulting error toast then reports the opposite action from what the user actually requested (e.g., “Failed to disconnect” when the user clicked connect).

Impact

Users can receive misleading error messages after a failed toggle. The intended action is not captured at click time, so the error path cannot reliably describe what the user was trying to do.

## Problem In `toggleTailscale()`, the error message logic in `toggleProcess.onExited` decides the action verb by reading the live property: ```js var action = root.isConnected ? "disconnect" : "connect" ``` `root.isConnected` is updated asynchronously by the 5-second `statusCheck` timer. If a status poll completes between the user click and the toggle process exit, `isConnected` may already reflect the new state. The resulting error toast then reports the opposite action from what the user actually requested (e.g., “Failed to disconnect” when the user clicked connect). ## Impact Users can receive misleading error messages after a failed toggle. The intended action is not captured at click time, so the error path cannot reliably describe what the user was trying to do.

vybe referenced this issue

2026-05-19 04:30:56 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe referenced this issue

2026-05-19 05:17:22 +00:00

Remove redundant binaryAvailable guard from TailscaleWidget.qml #11

vybe referenced this issue

2026-05-19 05:22:07 +00:00

Missing edge-case tests for parsePeers and findActiveExitNode #21

vybe referenced this issue

2026-05-19 05:47:19 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe referenced this issue

2026-05-19 06:49:38 +00:00

Lax / fragmented error handling throughout the widget (catch-all masking, missing exit checks, no stderr) #29

vybe referenced this issue from a commit

2026-05-21 07:04:34 +00:00

fix: capture intended toggle action at click time to avoid stale isConnected in error toast

vybe referenced this issue from a commit

2026-05-21 07:04:34 +00:00

Merge feature_fix_toggle_error_action into vibes

vybe commented

2026-05-21 07:04:35 +00:00

Author

Collaborator

Fixed: now captures intended action ('connect'/'disconnect') in _pendingToggleAction at click time (TailscaleWidget.qml:115). onExited uses captured value instead of live isConnected. Merged to vibes. Written by AI agent working for @jtmorris. Model: Grok 4.3.

vybe commented

2026-05-21 07:16:43 +00:00

Author

Collaborator

Resolved via merge 4c172e9. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.

Resolved via merge 4c172e9. The plugin is confirmed working by @jtmorris. Human code review required before merging to testing.

vybe closed this issue

2026-05-21 07:16:43 +00:00

vybe referenced this issue from a commit

2026-05-21 09:19:17 +00:00

fix: capture intended toggle action at click time to avoid stale isConnected in error toast

vybe referenced this issue from a commit

2026-05-25 03:00:46 +00:00

fix: capture intended toggle action at click time to avoid stale isConnected in error toast

Rows
Columns

Toggle error message can report the opposite action due to stale isConnected state #14

Problem

Impact